Item11740: Create pattern theme for jquery elements

Priority: Enhancement
Current State: Closed
Released In: 1.1.6
Target Release: patch
Applies To: Extension
Component: PatternSkin
Branches: Release01x01 trunk
Reported By: ArthurClemens
Waiting For: ArthurClemens
Last Change By: GeorgeClark
Currently trunk only.

-- ArthurClemens - 09 Apr 2012

You added some files to the MANIFEST, but you forgot to check them in smile

-- PaulHarvey - 10 Apr 2012

Sorry Arthur, I've reverted so that I could work done on trunk.

  • We were missing the .css/pngs which the theme requires
  • Created Item11741 to separate out the jsonpreferences zone stuff
  • Let's not hijack benign tasks (add a theme) with work that drastically changes the way we do prefs in Foswiki (I assume it was by accident)

Let me know if you want some help

-- PaulHarvey - 10 Apr 2012

Argh what a mess. FOSWIKI.pm changes should not have been committed except for the version number. I totally forgot it had more changes.

-- ArthurClemens - 10 Apr 2012

Why don't you add the theme to the PatternSkin instead? Themes are pluggable like any other jquery plugin is. Themes can be packaged as a contrib. So ...

-- MichaelDaum - 10 Apr 2012

That is a possibility. But is it better?

-- ArthurClemens - 10 Apr 2012

Add this to PatternSkin's Config.spec:

# ---++ JQueryPlugin
# ---+++ Extra themes

# **STRING**
$Foswiki::cfg{JQueryPlugin}{Themes}{Pattern}{Url} = '%PUBURLPATH%/%SYSTEMWEB%/PatternSkin/jquery-ui.css';

# **BOOLEAN**
$Foswiki::cfg{JQueryPlugin}{Themes}{Pattern}{Enabled} = 1;

That's better because the PatternSkin design will stay in sync with its own jquery ui theme. So when you change something in the design that needs changes to the ui theme as well, you can release both in one chunk instead of having to release a new JQueryPlugin as well. If you decide not to ship PatternSkin with foswiki any more, you won't need the pattern ui theme either, would you?

-- MichaelDaum - 11 Apr 2012

How can I make this theme selectable? If it is in "Extra themes", it is not in the dropdown at {JQueryTheme}.

-- ArthurClemens - 16 Jun 2012

Is this ready for 1.1.6? The JQuery commits have been merged to 1.1.6, where does pattern skin stand? Waiting for release?

-- GeorgeClark - 28 Jul 2012

Hi Arthur/Michael,

We're still missing a few files according the MANIFEST,
WARNING: Cannot find source file for /usr/local/src/github.com/foswiki/PatternSkin/pub/System/PatternSkinTheme/jquery-ui.css
WARNING: Cannot find source file for /usr/local/src/github.com/foswiki/PatternSkin/pub/System/PatternSkinTheme/jquery-ui.css.gz
WARNING: Cannot find source file for /usr/local/src/github.com/foswiki/PatternSkin/pub/System/PatternSkinTheme/jquery-ui.uncompressed.css

-- PaulHarvey - 26 Sep 2012 - 04:35

For release branch this is included in Item12220.

-- ArthurClemens - 02 Nov 2012
Topic revision: r29 - 02 Dec 2012, GeorgeClark
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License