Item8938: bogus handleKeyDown event handler in edit.pattern.tmpl

Priority:	CurrentState:	AppliesTo:	Component:	WaitingFor:
Normal	No Action Required	Extension	PatternSkin

Hi Arthur, can we kill this handleKeyDown event handler? There's no code for it and it makes the JS error logs quite noisy

Index: trunk/PatternSkin/templates/edit.pattern.tmpl
===================================================================
--- trunk/PatternSkin/templates/edit.pattern.tmpl   (revision 7231)
+++ trunk/PatternSkin/templates/edit.pattern.tmpl   (working copy)
@@ -61,7 +61,7 @@
 %TMPL:DEF{"pagehelp"}%%TWISTYTOGGLE{id="edithelp" mode="div" remember="on" noscript="hide"}%<div class="foswikiHelp">%TMPL:P{"help"}%%TMPL:P{"actionbuttons_help"}%</div>%ENDTWISTYTOGGLE%%TMPL:END%
 
 
-%TMPL:DEF{"textarea"}%%TMPL:P{"forceie8compatibilitymode"}%<div class="patternEditTopic"><textarea class="foswikiTextarea foswikiEditboxStyleProportional foswikiWysiwygEdit" id="topic" name="text" rows="%EDITBOXHEIGHT%" cols="%EDITBOXWIDTH%" style='%EDITBOXSTYLE%' onkeydown='handleKeyDown(event)'>%TEXT%</textarea>%TMPL:P{"sig_textareabuttons"}%</div><!--/patternEditTopic-->%TMPL:END%
+%TMPL:DEF{"textarea"}%%TMPL:P{"forceie8compatibilitymode"}%<div class="patternEditTopic"><textarea class="foswikiTextarea foswikiEditboxStyleProportional foswikiWysiwygEdit" id="topic" name="text" rows="%EDITBOXHEIGHT%" cols="%EDITBOXWIDTH%" style='%EDITBOXSTYLE%'>%TEXT%</textarea>%TMPL:P{"sig_textareabuttons"}%</div><!--/patternEditTopic-->%TMPL:END%
 
 
 %TMPL:DEF{"sig_textareabuttons"}%<div class="patternSigLine">%IF{"not context TinyMCEPluginEnabled or $nowysiwyg='1' or $NOWYSIWYG='1'" then='%TMPL:P{"textareabuttons"}%'}%%TMPL:P{"sig"}%<br class="foswikiClear" /></div><!-- /patternSigLine-->%TMPL:END%

-- PaulHarvey - 21 Apr 2010

Yes, it has been there for legacy reasons (and apparently not supported). Instead we should have a warning like TinyMCE to warn if you navigate away from the page.

-- ArthurClemens - 21 Apr 2010

Changing this to no action required. The code in question is not in the current pattern skin release.

-- GeorgeClark - 13 Mar 2011