Item12381: Configure UI and help text review
Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component: Configure
Branches: trunk master
General review and cleanup of the configure help text,
--
GeorgeClark - 03 Feb 2013
getRawValue()
still expands contained references to
$Foswiki::cfg
Example:
$Foswiki::cfg{ScriptUrlPath}/view$Foswiki::cfg{ScriptSuffix}
getRawValue() returns
/bin/view
As a consequence the UI doesn't display any
Expands to: ...
See the defaulf for
{ScriptUrlPaths}{view}
.
--
MichaelDaum - 17 Jan 2015
The problem is deeper than
getRawValue()
I've changed that code from an eval, do a recursive loop indexing through the keys, with no use of eval. There should be no way for that code to expand the embedded variables.
I think we need to find anyplace where configure uses eval (\$Foswiki::cfg$k) to dynamically access the hash and change it to a loop. Or find some other clever way to step into a hash without use of eval.
I've traced it specifically to the
Configure::Query::_getSetParams()
. When it does the eval to set the key, it expands it.
--
GeorgeClark - 17 Jan 2015
Yea that seems to be a good idea. For now I get lots of errors of the form
Use of uninitialized value in string at (eval 20898) line 1.
presumably as a consequence of
$k
not being defined sometimes.
--
MichaelDaum - 17 Jan 2015
No, getRaw was failing for undefined keys that have spec. No need to do an assignment, just return the undef. fixed.
--
GeorgeClark - 18 Jan 2015