NOTE: If you are a developer, please use a private wiki based on foswiki/trunk on a daily base ...or use trunk.foswiki.org to view this page for some minimal testing.
Use Item9693 for docu changes for 1.2 and 2.0.
You are here: Foswiki>Tasks Web>Item11587 (06 May 2013, MichaelDaum) Edit this topic text (e) Attach an image or document to this topic; manage existing attachments (a) View sequential topic history View without formatting (v) Create new topic Printable version of this topic (p) More: delete or rename this topic; set parent topic; view and compare revisions (m)

Item11587: Calls to deprecated readTopicText and saveTopicText are in several public extensions

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal New Extension ActionTrackerPlugin, AttachContentPlugin, BioKbPlugin, ChecklistPlugin, ChecklistTablePlugin, CommentPlugin, ControlWikiWordPlugin, DBIQueryPlugin, DbXmlPlugin, DirectedGraphWebMapPlugin, EditHiddenTablePlugin, EditSyntaxPlugin, EditTablePlugin, EditTablerowPlugin, EmbedTopicPlugin, ExcelImportExportPlugin, FormPlugin, FormQueryPlugin, GenPDFAddOn, GenPDFLatexAddOn, GetAWebPlugin, GitPlugin, GlobalReplacePlugin, GpgkeyPlugin, ImmediateNotifyPlugin, ImportExportPlugin, IncludeRevisionPlugin, InterwikiPlugin, InterwikiPreviewPlugin, KinoSearchContrib, MailReminderPlugin, MailerContrib, MsOfficeAttachmentsAsHTMLPlugin, NavPlugin, OrphansPlugin, PhotoarchivePlugin, PollPlugin, ProjectPlannerPlugin, PublishWebPlugin, RackPlannerPlugin, RandomQuotePlugin, ReadWriteOfflinePlugin, RenderFormPlugin, RenderTableDataPlugin, SetTopicValuesPlugin, SignaturePlugin, SmiliesPlugin, TWikiCompatibilityPlugin, TablePlugin, TimeTablePlugin, TopicReferencePlugin, UnitTestContrib, ValidateUrlsPlugin, XmlQueryPlugin, YetAnotherXpTrackerPlugin  
The Foswiki::Func::saveTopicText and Foswiki::Func::readTopicText APIs are inefficient and deprecated for many years (and according to SvenDowideit, broken).

The following public extensions use saveTopicText:

The following extensions also use saveTopicText, but only in tests (where it is marginally acceptable)

From a brief review of the usages, most are trivial to fix and are probably a result of a mistaken belief that this function is more efficient than saveTopic. Some are a result of a paired usage of readTopicText

The following extensions use =readTopicText in code:

And in tests:

-- CrawfordCurrie - 29 Feb 2012

 

ItemTemplate edit

Summary Calls to deprecated readTopicText and saveTopicText are in several public extensions
ReportedBy CrawfordCurrie
Codebase trunk
SVN Range
AppliesTo Extension
Component ActionTrackerPlugin, AttachContentPlugin, BioKbPlugin, ChecklistPlugin, ChecklistTablePlugin, CommentPlugin, ControlWikiWordPlugin, DBIQueryPlugin, DbXmlPlugin, DirectedGraphWebMapPlugin, EditHiddenTablePlugin, EditSyntaxPlugin, EditTablePlugin, EditTablerowPlugin, EmbedTopicPlugin, ExcelImportExportPlugin, FormPlugin, FormQueryPlugin, GenPDFAddOn, GenPDFLatexAddOn, GetAWebPlugin, GitPlugin, GlobalReplacePlugin, GpgkeyPlugin, ImmediateNotifyPlugin, ImportExportPlugin, IncludeRevisionPlugin, InterwikiPlugin, InterwikiPreviewPlugin, KinoSearchContrib, MailReminderPlugin, MailerContrib, MsOfficeAttachmentsAsHTMLPlugin, NavPlugin, OrphansPlugin, PhotoarchivePlugin, PollPlugin, ProjectPlannerPlugin, PublishWebPlugin, RackPlannerPlugin, RandomQuotePlugin, ReadWriteOfflinePlugin, RenderFormPlugin, RenderTableDataPlugin, SetTopicValuesPlugin, SignaturePlugin, SmiliesPlugin, TWikiCompatibilityPlugin, TablePlugin, TimeTablePlugin, TopicReferencePlugin, UnitTestContrib, ValidateUrlsPlugin, XmlQueryPlugin, YetAnotherXpTrackerPlugin
Priority Normal
CurrentState New
WaitingFor
Checkins Foswikirev:15375 Foswikirev:16702
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches trunk
trunkCheckins Foswikirev:15375 Foswikirev:16702
Release01x01Checkins
Edit | Attach | Print version | History: r6 < r5 < r4 < r3 | Backlinks | View wiki text | Edit wiki text | More topic actions
Topic revision: r6 - 06 May 2013, MichaelDaum
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons LicenseGet Foswiki at sourceforge.net. Fast, secure and Free Open Source software downloads