Item11111: Add facebox plugin
Priority: Enhancement
Current State: No Action Required
Released In: n/a
Target Release: n/a
https://github.com/defunkt/facebox
--
ArthurClemens - 05 Sep 2011
Arthur could you please revert this and make it a plugin of its own. We already have too much in
JQueryPlugin itself.
--
MichaelDaum - 06 Sep 2011
How many is too many? I thought this was the setup of JQueryPlugin.
I thought this is a nice plugin for showing attachment info for BaseSkin.
--
ArthurClemens - 06 Sep 2011
Too many is the number of alternatives we already have in
JQueryPlugin.
There are too many modal dialog alternatives and lightbox plugins, even more waiting to be foswikified ... but not as part
of
JQueryPlugin itself.
Please revert.
Next time: let's talk first before adding stuff.
--
MichaelDaum - 06 Sep 2011
Fine
--
ArthurClemens - 06 Sep 2011
In svn there's JQueryExtrasPlugin and EmptyJQueryPlugin for examples
--
PaulHarvey - 06 Sep 2011
For core functionalities you don't want to load extra plugins. JQuery is always available, and that makes distributing jquery plugins very easy. I agree that we should not dump everything into it, but currently this feels too arbitrary (the plugin 'owner' dictates what's in).
--
ArthurClemens - 07 Sep 2011
JQueryPlugin follows release process now. I guess it's "just" a matter of doing a feature proposal, and figuring out a strategy to retire slimbox (or help me understand why both are necessary
--
PaulHarvey - 07 Sep 2011
Paul is right.
JQueryPlugin is a default plugin and it is not an individual that decides what goes in and what does not. New features in default plugins must happen through feature proposals.
Unless a new
JqueryPlugin feature is to be used in one of our default skins I agree with Michael that it is better to dstribute these plugins in separate Jquery enhancement plugins. Either on their own or in relevang bundles. And for those it is at the authors choice what is in.
--
KennethLavrsen - 07 Sep 2011