(r11) Item8521 < Tasks

NOTE: If you are a developer, please use a private wiki based on foswiki/trunk on a daily base ...or use trunk.foswiki.org to view this page for some minimal testing.
Use Item9693 for docu changes for 1.2 and 2.0.

You are here: Foswiki>Tasks Web>Component>ZonePlugin>Item8521 (revision 11) (raw view)

See [[Support.Question427]]

The BEGIN block of the ZonePlugin is executed by the plugin installer even when the plugin is disabled.  This causes all plugin installs to fail.  The workaround to allow plugin installation to proceed is to be sure that ZonePlugin is enabled in =LocalSite.cfg= if it is installed.

I locally tried the following patch to the BEGIN block and it appears to allow the installer to proceed - however I have not done much testing:

<verbatim>
# monkey-patch API ###########################################################
BEGIN {
  if ($Foswiki::cfg{Plugins}{ZonePlugin}{Enabled}) {
      no warnings 'redefine';
      *Foswiki::Func::addToZone = \&Foswiki::Plugins::ZonePlugin::addToZone;
      *Foswiki::Func::addToHEAD = \&Foswiki::Plugins::ZonePlugin::addToHead;
  }
}
</verbatim>

-- Main.GeorgeClark - 13 Feb 2010



Why does ZonePlugin get compiled even though it is disabled?

-- %USERSWEB%.MichaelDaum - 14 Feb 2010


Someone who knows / understands the internals of configure and the installer scripts might know - I don&#39;t.   Maybe part of the installer error checking?    In any event, it pretty thoroughly breaks bin/configure and xxxxx_installer scripts.  Two sites reported errors in Support / IRC in less than 24 hours.

-- %USERSWEB%.GeorgeClark - 14 Feb 2010


The above patch looks pretty straight forward. Will add it asap.

-- %USERSWEB%.MichaelDaum - 14 Feb 2010

Note that this issue appears to be also triggered by other plugin failures.  See [[Item2595]] where a plugin issue disrupts plugin installation.

-- Main.GeorgeClark - 14 Feb 2010

Should be fixed in v1.1

-- Main.MichaelDaum - 15 Feb 2010



Tiny tweak to config.spec so we can actually see the ZonePlugin options. Probably should have created a new task, but it was very minor change.

-- %USERSWEB%.PaulHarvey - 05 Mar 2010
%COMMENT%

ItemTemplate edit

Summary	ZonePlugin breaks plugin installer from both bin/configure and shell
ReportedBy	GeorgeClark
Codebase
SVN Range
AppliesTo	Extension
Component	ZonePlugin
Priority	Urgent
CurrentState	Closed
WaitingFor
Checkins	Foswikirev:6332 Foswikirev:6333 Foswikirev:6334
TargetRelease	n/a
ReleasedIn

Topic revision: r11 - 05 Mar 2010, PaulHarvey

Tasks

Submit and Query

Create Task

Developer Tasks

Non Developer Tasks

Developer Tools

Tools

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement.