(r10) Item11624 < Tasks

NOTE: If you are a developer, please use a private wiki based on foswiki/trunk on a daily base ...or use trunk.foswiki.org to view this page for some minimal testing.
Use Item9693 for docu changes for 1.2 and 2.0.

You are here: Foswiki>Tasks Web>Item11624 (revision 10) (raw view)

resulting in bizzareness like:

<verbatim>
META:TOPICINFO{author="sven" comment="reprev" date="1331186181" format="1.1" reprev="8" version="10"}
</verbatim>

anyone testing for topicinfo.reprev in an If or query will be stuffed up a bit.

-- Main.SvenDowideit - 08 Mar 2012

First question is, why would anyone be searching for a reprev? The reprev is only relevant when reprev==version, which is an indicator that version was generated by a reprev. Yes, it's noise once version is incremented, but it's also harmless, I think.

Why is this Urgent? I don't see how it can be a release blocker. The following patch probably removes redundant reprev, but I'm not convinced it's worth bothering with.

<verbatim>
Index: lib/Foswiki/Store/VC/Store.pm
===================================================================
--- lib/Foswiki/Store/VC/Store.pm	(revision 14255)
+++ lib/Foswiki/Store/VC/Store.pm	(working copy)
@@ -117,6 +117,7 @@
         for my $i (qw(author version date)) {
             $ri->{$i} = $truth->{$i};
         }
+	undef $ri->{reprev};
     }
 
     $gotRev = $version;
Index: lib/Foswiki/Meta.pm
===================================================================
--- lib/Foswiki/Meta.pm	(revision 14255)
+++ lib/Foswiki/Meta.pm	(working copy)
@@ -1865,6 +1865,9 @@
     # (side effect of getRevisionInfo)
     $this->getRevisionInfo();
 
+    # Clear the reprev flag
+    undef $this->get('TOPICINFO')->{reprev};
+
     # Semantics inherited from Cairo. See
     # Foswiki:Codev.BugBeforeSaveHandlerBroken
     if ( $plugins->haveHandlerFor('beforeSaveHandler') ) {
@@ -3552,8 +3555,11 @@
         # when old code (e.g. old plugins) generated the meta.
         $ti->{version} = Foswiki::Store::cleanUpRevID( $ti->{version} );
         $ti->{rev} = $ti->{version};    # not used, maintained for compatibility
-        $ti->{reprev} = Foswiki::Store::cleanUpRevID( $ti->{reprev} )
-          if defined $ti->{reprev};
+	if ( defined $ti->{reprev} ) {
+	    $ti->{reprev} = Foswiki::Store::cleanUpRevID( $ti->{reprev} );
+	    undef $ti->{reprev} unless $ti->{reprev} &&
+		$ti->{version} &&
+		$ti->{reprev} == $ti->{version};
     }
     else {
 
</verbatim>

Marking for Sven's feedback to understand why this is so important.

-- Main.CrawfordCurrie - 09 Mar 2012



mostly, I worry that releasing inconsistent user facing things will lead to our needing to support them in future. 

So if someone wants to test for reprev - for eg a UI icon, and then stumbles upon this, they then add the extra workaround that you mention (ie, convert the IF from =defined info.reprev= to =info.reprev == info.version= - or worse, =info.comment == 'reprev'= 

then later we need to make _all_ serialisations continue to support this - including writing unit tests, docco and other much harder to support mess.

I didn't mean to commit this yet though, as I want to write unit tests for it. - work in progress for 1.1.5.


-- %USERSWEB%.SvenDowideit - 14 Mar 2012

George reverted, and i don't see hwo i can write the unit tests quickly enough, i'm sick.

so defer til 1.2.0 probably.

-- Main.SvenDowideit - 21 Mar 2012

%COMMENT%

ItemTemplate edit

Summary	reprev comment and number persists in TOPICINFO long after the event.
ReportedBy	SvenDowideit
Codebase	1.1.4, trunk
SVN Range
AppliesTo	Engine
Component
Priority	Urgent
CurrentState	Waiting for Feedback
WaitingFor	SvenDowideit
Checkins	Foswikirev:14308 Foswikirev:14309 Foswikirev:14358 Foswikirev:14362 Foswikirev:14363 Foswikirev:14364
TargetRelease	minor
ReleasedIn	1.2.0
CheckinsOnBranches	Release01x01
trunkCheckins
Release01x01Checkins	Foswikirev:14308 Foswikirev:14309 Foswikirev:14358 Foswikirev:14362 Foswikirev:14363 Foswikirev:14364

Topic revision: r10 - 21 Mar 2012, SvenDowideit

Tasks

Submit and Query

Create Task

Developer Tasks

Non Developer Tasks

Developer Tools

Tools

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement.