(r2) Item11607 < Tasks

NOTE: If you are a developer, please use a private wiki based on foswiki/trunk on a daily base ...or use trunk.foswiki.org to view this page for some minimal testing.
Use Item9693 for docu changes for 1.2 and 2.0.

You are here: Foswiki>Tasks Web>Item11607 (revision 2) (raw view)

=Foswiki::Macros::REVARG= and =Foswiki::Macros::REVTITLE= are undocumented macros, and are redundantly expanded as System.SkinTemplateTokens.

<verbatim>
$: /var/www/foswiki/trunk/core/lib (master)$ grep -r %REVARG% *

Foswiki/UI/View.pm:    $tmpl =~ s/%REVARG%/$revArg/g;

$: /var/www/foswiki/trunk/core/lib (master)$ grep -r %REVTITLE% *
                                                                                                                                              
Foswiki/UI/View.pm:    $tmpl =~ s/%REVTITLE%/$revTitle/g;
Foswiki/UI/RDiff.pm:            $tailResult =~ s/%REVTITLE%/$revTitle/go;
Foswiki/Contrib/MailerContrib.pm:    $tmpl =~ s/%REVTITLE%//g;
</verbatim>

I suspect that they should either be macros, or template tokens, not both, otherwise it's possible to get inconsistent results.  Also changes to sanitize the macros needs to be kept consistent with the code in the scripts.

Finally not sure if it's a bug, but if an invalid but legal rev. is requested, it's displayed.  It should probably match the actual displayed revision and not the requested revision when the requested rev. doesn't exist.

Note also that the compare and rdiff scripts use modified versions as Template Tokens - REVTITLE1 and REVTITLE2

-- Main.GeorgeClark - 05 Mar 2012





Added the documentation for REVARG and REVTITLE under task Item11383.  

-- %USERSWEB%.GeorgeClark - 07 Mar 2012
%COMMENT%

ItemTemplate edit

Summary	REVARG and REVTITLE are undocumented macros, and expanded as both a macro and a formatting token
ReportedBy	GeorgeClark
Codebase	1.1.4, trunk
SVN Range
AppliesTo	Engine
Component	Documentation, FoswikiUIRDiff, FoswikiUIView, MailerContrib, REVARG, REVTITLE
Priority	Normal
CurrentState	Confirmed
WaitingFor
Checkins
TargetRelease	minor
ReleasedIn	1.2.0
CheckinsOnBranches
trunkCheckins
Release01x01Checkins

Topic revision: r2 - 07 Mar 2012, GeorgeClark

Tasks

Submit and Query

Create Task

Developer Tasks

Non Developer Tasks

Developer Tools

Tools

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement.