I had written an improvement but only half of it and this was also not put in release branch. But the old code is broken, so kind of urgent.

-- ArthurClemens - 02 Nov 2011

Arthur, I've updated foswiki.org with the latest version of PatternSkin that you just released, disabled my cache, cleared everything - no luck on that attachment counter. Works on trunk though.

I've compared all the files between Trunk and Release11 Pattern Skin - lots of differences - paged through all the output from find PatternSkin -type f -exec git diff master:{} release11:{} \; All of these files had differences - some pretty significant. Also attached the complete git diff output for you - see the attachment table - without counter below.

+++ b/release11:PatternSkin/templates/foswiki.pattern.tmpl
+++ b/release11:PatternSkin/templates/viewprint.pattern.tmpl
+++ b/release11:PatternSkin/templates/viewsidebar.pattern.tmpl
+++ b/release11:PatternSkin/templates/attachtables.pattern.tmpl
+++ b/release11:PatternSkin/templates/login.sudo.pattern.tmpl
+++ b/release11:PatternSkin/templates/viewtopbar.pattern.tmpl
+++ b/release11:PatternSkin/templates/edit.pattern.tmpl
+++ b/release11:PatternSkin/templates/view.pattern.tmpl
+++ b/release11:PatternSkin/lib/Foswiki/Contrib/PatternSkin.pm
+++ b/release11:PatternSkin/pub/System/PatternSkinThemeFatWilly/style_src.css
+++ b/release11:PatternSkin/pub/System/PatternSkin/pattern_src.js
+++ b/release11:PatternSkin/pub/System/PatternSkinTheme2009/style.css
+++ b/release11:PatternSkin/pub/System/PatternSkinTheme/style_src.css
+++ b/release11:PatternSkin/data/Main/PatternSkinUserViewTemplate.txt
+++ b/release11:PatternSkin/data/System/PatternSkinElements.txt
+++ b/release11:PatternSkin/data/System/PatternSkinHorizontalNavigationExample.txt
+++ b/release11:PatternSkin/data/System/PatternSkin.txt
+++ b/release11:PatternSkin/data/System/PatternSkinColorSettings.txt

I skipped the topics that were only different in the TOPICINFO.

-- GeorgeClark - 02 Nov 2011

Apparently:

• Javascript works in jquery 1.4.3, but not in 1.6.
• Trunk uses QUERY counter instead of javascript

I have changed release branch to also use QUERY. The FW 1.0 fallback template does not show a counter.

-- ArthurClemens - 02 Nov 2011